[WIP][ENG-6650] gravyboa: update boa addon to pull creds from gravyvalet if flag is set #10823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felliott
force-pushed
the
feature/gravyboa
branch
from
2ad29a2 to
1bd05ab
Compare
* If the GV waffle flag is set, pull auth from gravyvalet rather than the osf addon * Update fakes to support computing addons, but don't start testing them yet! That'll come later.
felliott
force-pushed
the
feature/gravyboa
branch
from
1bd05ab to
c08cf48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Changes
Update the boa addon to pull credentials and setting from gravyvalet if the GV waffle flag is set.
Also update
gv_fakesfor remote-computing support (though this is not yet tested)QA Notes
I will be QAing this
Documentation
None expected
Side Effects
None expected
Ticket
https://openscience.atlassian.net/browse/ENG-6650